[llvm] r273961 - [PM] Improve the debugging and logging facilities of the CGSCC bits of

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 6 16:08:40 PDT 2016


On Wed, Jul 6, 2016 at 11:44 AM, Chandler Carruth <chandlerc at gmail.com> wrote:
> On Tue, Jul 5, 2016 at 5:19 PM Davide Italiano via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>>
>> On Mon, Jun 27, 2016 at 4:26 PM, Chandler Carruth via llvm-commits
>> <llvm-commits at lists.llvm.org> wrote:
>> > Author: chandlerc
>> > Date: Mon Jun 27 18:26:08 2016
>> > New Revision: 273961
>> >
>> > URL: http://llvm.org/viewvc/llvm-project?rev=273961&view=rev
>> > Log:
>> > [PM] Improve the debugging and logging facilities of the CGSCC bits of
>> > the new pass manager.
>> >
>> > This adds operator<< overloads for the various bits of the
>> > LazyCallGraph, dump methods for use from the debugger, and debug logging
>> > using them to the CGSCC pass manager.
>> >
>> > Having this was essential for debugging the call graph update patch, and
>> > I've extracted what I could from that patch here to minimize the delta.
>> >
>> > Modified:
>> >     llvm/trunk/include/llvm/Analysis/CGSCCPassManager.h
>> >     llvm/trunk/include/llvm/Analysis/LazyCallGraph.h
>> >     llvm/trunk/lib/Analysis/LazyCallGraph.cpp
>> >     llvm/trunk/lib/Passes/PassBuilder.cppHi Hi
>> >     llvm/trunk/test/Other/new-pass-manager.ll
>> >
>>
>> Hi Chandler, this breaks the build with GCC6. Can you please take a look?
>
>
> Yikes, just back from the holiday weekend and looking at this. Is there a
> build bot with this configuration? I'm worried I may not get it on my first
> shot...
>

After a discussion with Chandler on IRC, we agreed this is a bug in
GCC. No bot uses GCC6 yet but we might want to consider disabling the
warning to avoid false positives like this one.

Thanks,

--
Davide


More information about the llvm-commits mailing list