[PATCH] D18278: llvm-cov HTML Generation

[Vedant Kumar via llvm-commits]

vsk marked an inline comment as done.
vsk added a comment.

In http://reviews.llvm.org/D18278#475852, @MatzeB wrote:

> Definitely a nice feature to have (I assume we can replace http://llvm.org/reports/coverage/ with this at some point).


We certainly hope to make it competitive :).

> I didn't have time to actually try it out, so no comments on the looks of the generated pages here.


The link might have gotten lost above. Here's a sample: http://net.vedantk.com/static/bitcode-compatibility-coverage.dir.tar.gz.

> While I like the fact that a stylesheet is hardcoded by default, I can imagine some users wanting to tweak it. Adding an option that generates a `<link rel="stylesheet"...` instead of outputting the hardcoded stylesheet should be easy.

>  You could address this in followup patches though.


I'll fix this in a follow-up. I'd also like to add a `-demangler` option.


================
Comment at: tools/llvm-cov/HTMLCoverage.inc:1
@@ +1,2 @@
+//===- HTMLCoverage.inc - Helper definitions for html output --------------===//
+//
----------------
MatzeB wrote:
> Using a .inc file feels slightly unusual for llvm. Why not call this HTMLCoverage.h or alternatively simply copy the contents to the beginning of HTMLCoverageViewHTML.cpp...
Fair point, I'll move this into the SourceCoverageViewHTML.cpp.


http://reviews.llvm.org/D18278