[PATCH] D22015: [ELF] Introduce a flag to parse response file according to windows rules

[Davide Italiano via llvm-commits]

davide added a comment.

In http://reviews.llvm.org/D22015#475966, @ruiu wrote:

> LGTM
>
> OK, I'll make a follow-up patch for this, but I'd like to say that it is important to keep code consistent in style and taste, and code review is a way to achieve it, so I'm not nitpicking.




In http://reviews.llvm.org/D22015#475966, @ruiu wrote:

> LGTM
>
> OK, I'll make a follow-up patch for this, but I'd like to say that it is important to keep code consistent in style and taste, and code review is a way to achieve it, so I'm not nitpicking.


For this reason some projects have an official style guide, e.g. https://www.freebsd.org/cgi/man.cgi?query=style&sektion=9

Also, please note that LLVM is not always consistent with itself, and lld is a clear example.
Two differences that come to my mind are:

1. Lto instead of LTO, Elf instead of ELF
2. Not using auto unless it's really obvious from the context

So having a full set of "rules" or recommendations somewhere will be ideal, and I hope you can contribute those as it seem you care about the most. We have codingstandards but it doesn't seem to cover everything you want.

Thanks!


http://reviews.llvm.org/D22015