[PATCH] D21395: Fix for Bug 28144

Vivek Pandya via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 6 13:06:21 PDT 2016

vivekvpandya added inline comments.

Comment at: lib/CodeGen/MachineRegisterInfo.cpp:511
@@ -509,3 +510,3 @@
     for (const MachineOperand &MO : make_range(def_begin(*AI), def_end())) {
-      if (isNoReturnDef(MO))
+      if (!SkipNoReturnDef && isNoReturnDef(MO))
mehdi_amini wrote:
> Do you have a test for that?
> Are you fixing two different bugs here?
No this not fix for local function related bug, but this is for code reusability. As per discussion with MtazeB and Hal method to calculate register usage is same except isNoReturnDef is not required. So we decide to add a parameter with optional value. I don't think we require test case for this.


More information about the llvm-commits mailing list