[llvm] r274648 - [X86][SSE] Fixed typo in insertps lowering.

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 6 11:09:08 PDT 2016

Author: rksimon
Date: Wed Jul  6 13:09:08 2016
New Revision: 274648

URL: http://llvm.org/viewvc/llvm-project?rev=274648&view=rev
[X86][SSE] Fixed typo in insertps lowering.

We were checking for 2 insertions (which is caught earlier in the pattern matching loop) instead of the case where we have no insertions.

Turns out this code never fires as we always try to lower to insertps after trying to lower to blendps, which would catch these cases - I'm about to make some changes to support combining to insertps which could cause this to fire so I don't want to remove it.


Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=274648&r1=274647&r2=274648&view=diff
--- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Wed Jul  6 13:09:08 2016
@@ -8719,7 +8719,7 @@ static SDValue lowerVectorShuffleAsInser
   // Don't bother if we have no (non-zeroable) element for insertion.
-  if (V1DstIndex >= 0 && V2DstIndex >= 0)
+  if (V1DstIndex < 0 && V2DstIndex < 0)
     return SDValue();
   // Determine element insertion src/dst indices. The src index is from the

More information about the llvm-commits mailing list