[PATCH] D21952: [compiler-rt] Fix VisualStudio virtual folders layout

Etienne Bergeron via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 6 08:39:30 PDT 2016


etienneb added inline comments.

================
Comment at: test/asan/CMakeLists.txt:106
@@ -105,3 +105,3 @@
   DEPENDS ${ASAN_TEST_DEPS})
-set_target_properties(check-asan PROPERTIES FOLDER "ASan tests")
+set_target_properties(check-asan PROPERTIES FOLDER "Compiler-RT Misc")
 
----------------
rnk wrote:
> Not "Compiler-RT Tests"?
The reason it's like that is to group the "Executables" together.
So, under "Compiler-RT tests" you have executables.
The "Misc" is used for the PHONY rules.

I don't have a strong opinion on where we should put them.


http://reviews.llvm.org/D21952





More information about the llvm-commits mailing list