[PATCH] D22036: [polly] Add accelerator code generation pass sceleton

Tobias Grosser via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 6 05:43:02 PDT 2016

grosser added a comment.

In http://reviews.llvm.org/D22036#475040, @Meinersbur wrote:

> In http://reviews.llvm.org/D22036#475026, @grosser wrote:
> > In http://reviews.llvm.org/D22036#475020, @Meinersbur wrote:
> >
> > > `PPCGCodeGenerationPass` sounds like it would invoke PPCG. I'd remove PPCG from the name, keeping only ACC.
> >
> >
> > It will, internally. If you prefer, I can still rename this pass to AcceleratorCodeGenerationPass.
> I didn't even know that PPCG has an interface for this. I'll wait further comments until I see the larger code base. Rename at your own discretion.

PPCG does not, but the changes to use it as a library are very limited. I plan to first apply these changes in the Polly repository and -- after we gained some experience -- upstream them to the official ppcg.

OK. Then I will probably leave PPCG in the name for now.

Comment at: lib/Support/RegisterPasses.cpp:90
@@ +89,3 @@
+static cl::opt<bool> PollyACC("polly-acc",
+                              cl::desc("Enable accelerator code generation"),
+                              cl::Hidden, cl::init(false), cl::ZeroOrMore,
Meinersbur wrote:
> "Enable" sounds like this would add accelerator code generation to the other optimizations, but effectively replaces them. Wouldn't an equivalent to -polly-vectorizer/-polly-code-generator be more appropriate?
I can use:


if this is preferable.

The existing -polly-code-generator=isl does not really have a useful meaning since we dropped support for CLooG.


More information about the llvm-commits mailing list