[PATCH] D22015: [ELF] Introduce a flag to parse response file according to windows rules

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 6 05:32:26 PDT 2016

In addition to Sean suggestion, I think the default value should be
host dependent, so

* --rsp-quoting=windows -> always use windows style
* --rsp-quoting=posix -> always use posix style
* --rsp-quoting not passed, windows if running on win32 and posix otherwise.

Other than that LGTM.


On 5 July 2016 at 20:57, Sean Silva <chisophugis at gmail.com> wrote:
> silvas added a subscriber: silvas.
> silvas added a comment.
> Slight bikeshed, but Clang already has an option `--rsp-quoting=windows` `--rsp-quoting=posix`. Can we use that instead? In fact, you can probably just implement `--rsp-quoting=windows` by changing ` F<"use-windows-rsp">` to ` F<"rsp-quoting=windows">`.
> Other than that (which I don't feel strongly about) it seems fine to me.
> http://reviews.llvm.org/D22015

More information about the llvm-commits mailing list