[PATCH] D22036: Add accelerator code generation pass sceleton

Michael Kruse via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 6 04:34:07 PDT 2016


Meinersbur added a comment.

Title: "sceleton" -> "skeleton" and missing "[Polly]".

`PPCGCodeGenerationPass` sounds like it would invoke PPCG. I'd remove PPCG from the name, keeping only ACC.

Any chance to make PPCGCodeGenerationPass an alternative to the optimizer pass, or even merge it, such that the CodeGeneration would see what it has been optimized and generate the relevant code, just like OpenMP code generation. This would avoid copy&paste code duplication.


http://reviews.llvm.org/D22036





More information about the llvm-commits mailing list