[PATCH] D21561: [IPRA] Set callee saved registers to none for local function when IPRA is enabled.

Vivek Pandya via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 6 01:38:06 PDT 2016

vivekvpandya added inline comments.

Comment at: include/llvm/CodeGen/TargetPassConfig.h:23
@@ -21,1 +22,3 @@
+extern llvm::cl::opt<bool> UseIPRA;
 namespace llvm {
vivekvpandya wrote:
> mehdi_amini wrote:
> > I'm not sure it is fine to have a cl::opt in such a global header? If we need the option available broadly we may have to make it a member of `TargetPassConfig` initialized from a private cl::opt. 
> > (I haven't look in detail where it is needed though).
> UseIPRA  is used in TargetPassConfig and TargetFrameLoweringImpl
@MatzeB could you please provide some inputs?


More information about the llvm-commits mailing list