[PATCH] D18278: llvm-cov HTML Generation
Ying Yi via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 6 00:36:00 PDT 2016
MaggieYi added a comment.
In http://reviews.llvm.org/D18278#474741, @vsk wrote:
> Thanks for testing it out!
> It seems that all the pending issues we are discussing actually relate to `CoveragePrinter::getOutputPath`, which is not a part of this patch. We can fix them before or after this patch is committed, and test the changes using "-format text -output-dir ...".
> Given that this is a large change, I'd like to make sure it addresses Justin's concerns and that it has an explicit lgtm before moving forward.
I agree with you, we could fix these issues after the patch is committed.
The patch in the current state looks good to me.
More information about the llvm-commits