[PATCH] D21982: WIP: Implement a per-thread inmemory log

David Majnemer via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 5 22:13:51 PDT 2016


majnemer added inline comments.

================
Comment at: lib/xray/xray_inmemory_log.cc:71
@@ +70,3 @@
+    auto Written = write(Fd, Begin, Items * sizeof(XRayRecord));
+    if (Written <= 0) {
+      if (errno == EINTR)
----------------
I don't believe `write` can actually return zero for this case.


http://reviews.llvm.org/D21982





More information about the llvm-commits mailing list