[PATCH] D21091: AArch64: refactor sysreg handling (new TableGen backend!)

[Ahmed Bougacha via llvm-commits]

ab added inline comments.

================
Comment at: utils/TableGen/SearchableTableEmitter.cpp:232
@@ +231,3 @@
+                                         raw_ostream &OS) {
+  std::string TableName = InstanceClass->getName();
+  std::vector<Record *> Items = Records.getAllDerivedDefinitions(TableName);
----------------
t.p.northover wrote:
> ab wrote:
> > const&? Or is the copy intentional?
> getAllDerivedDefinitions returns an std::vector by value so I think they're equivalent (via RVO).
Ah, I meant for TableName


Repository:
  rL LLVM

http://reviews.llvm.org/D21091