[PATCH] D21779: [LTO] Infer EKind/EMachine from Bitcode files

[Davide Italiano via llvm-commits]

davide added a reviewer: atanasyan.

================
Comment at: lld/trunk/ELF/InputFiles.cpp:559-562
@@ +558,6 @@
+  Triple TheTriple(TripleStr);
+  bool Is64Bits = TheTriple.isArch64Bit();
+  if (TheTriple.isLittleEndian())
+    return Is64Bits ? ELF64LEKind : ELF32LEKind;
+  return Is64Bits ? ELF64BEKind : ELF32BEKind;
+}
----------------
dsanders wrote:
> Sorry for the late comment but Triple::isArch64Bit() doesn't correspond to ELF64 or ELF32 on MIPS. In particular, the triple used for the N32 ABI will return true for isArch64Bit() but this ABI uses ELF32 objects. If lld doesn't support the N32 ABI yet then the current code is ok for the remaining two ABI's (O32 and N64).
+ Simon as he wrote the MIPS support.


Repository:
  rL LLVM

http://reviews.llvm.org/D21779