[PATCH] D21526: [codeview] Improved array type support (multi dimension array)

Amjad Aboud via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 5 06:55:08 PDT 2016

aaboud marked 3 inline comments as done.

Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:933
@@ +932,3 @@
+  if (BaseType->getTag() == dwarf::DW_TAG_reference_type ||
+    BaseType->getTag() == dwarf::DW_TAG_rvalue_reference_type)
+    return DDTy->getSizeInBits();
rnk wrote:
> use clang-format here
> Can you give an example of when this would be needed? It would make a good test.
I am not sure there is an example where a base type of an array is a reference or rvalue reference.
I took this code from DwarfUnit.cpp, where it was used to determine base size of member types.

I would remove this code for now, unless you have other opinion.


More information about the llvm-commits mailing list