[PATCH] D21982: WIP: Implement a per-thread inmemory log

David Majnemer via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 5 01:25:35 PDT 2016


majnemer added inline comments.

================
Comment at: lib/xray/xray_inmemory_log.cc:123
@@ +122,3 @@
+      }
+      if (Written == 0 && TotalBytes != 0) {
+        printf("Failed to write; errno = %d", errno);
----------------
Isn't this code dead because your while condition requires Written to be non-zero?


http://reviews.llvm.org/D21982





More information about the llvm-commits mailing list