[PATCH] COFFObjectFile imports fix for compressed binaries

Bandzi Michal via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 4 14:10:48 PDT 2016


Unless I made some logical error I can't see, it should work that way,  
doesn't it?

if (lookupTable)
   return func(lookupTable, ...)
return func(addressTable, ...)

> I wonder if we should just rely on the ImportAddressTableRVA instead of
> first trying to use the ImportLookupTableRVA.
>
> What are your thoughts?
>
> On Mon, Jul 4, 2016 at 11:05 AM, Bandzi Michal <xbandz00 at stud.fit.vutbr.cz>
> wrote:
>
>> Cituji David Majnemer <david.majnemer at gmail.com>:
>>
>> Please clang-format the changes in your patch.
>>>
>>
>> Not sure what exactly this means. Found and used this:
>> http://clang.llvm.org/docs/ClangFormat.html#script-for-patch-reformatting
>> then created a new patch
>>
>> Also, LLVM does not use else after a return:
>>> http://llvm.org/docs/CodingStandards.html#don-t-use-else-after-a-return
>>>
>>
>> Hope this is better. New patch as attachement.
>>
>>
>





More information about the llvm-commits mailing list