[PATCH] D21964: [CFLAA] Moved StratifiedAttrs and summary-related stuffs out of CFLSteensAliasAnalysis

George Burgess IV via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 4 08:39:47 PDT 2016

george.burgess.iv added a subscriber: george.burgess.iv.
george.burgess.iv added a comment.

The mechanical refactors for this (and http://reviews.llvm.org/D21963) look good. I don't really
like throwing so many generally-named things into `llvm::`, though (e.g.
`llvm::EdgeType`, ...). Could we do something like putting all of this into
a `llvm::cflaa` namespace, please? If it makes life easier, feel free to
put `using namespace llvm::cflaa;` at the top of our cpp files. :)

(Same comments apply to 21963)

Thank you!


More information about the llvm-commits mailing list