[PATCH] D21890: [ELF] - Do not error out when version declaration not found when building executable.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 4 01:22:29 PDT 2016

grimar added inline comments.

Comment at: ELF/SymbolTable.cpp:194
@@ +193,3 @@
+  // In this case we just create new version.
+  if (!Config->Shared && !Config->VersionScript) {
+    Config->SymbolVersions.push_back(elf::Version(Version));
ruiu wrote:
> Is `!Config->VersionScript` the same as `Config->SymbolVersions.empty()`?
Not anymore. Because of next line:


So since we can create a new version now during SymbolTable<ELFT>::insert(), it is not the same.


More information about the llvm-commits mailing list