[PATCH] D18226: Codegen: Tail-duplicate during placement.

[Kyle Butt via llvm-commits]

iteratee marked 2 inline comments as done.
iteratee added a comment.

Please take a look at the tests again.


================
Comment at: test/CodeGen/PowerPC/tail-dup-analyzable-fallthrough.ll:7
@@ +6,3 @@
+; This test is checking for a bug where blocks with un-analyzable fallthrough
+; were getting tail-duplicated, leading to incorrect code. The loop-entry check
+; gets transformed to have a conditional exit, which is currently un-analyzable.
----------------
I simplified the code quite a bit. The essence of what was happening was a linked-list walk was getting miscompiled, so I shrunk it to that.

================
Comment at: test/CodeGen/PowerPC/tail-dup-layout.ll:4
@@ +3,3 @@
+target triple = "powerpc64le-grtev4-linux-gnu"
+
+; Intended layout:
----------------
OK, I made it look more like the other test that you pointed too, with repeated calls for bodies.


http://reviews.llvm.org/D18226