[PATCH] D21934: Address two correctness issues in LoadStoreVectorizer

Alina Sbirlea via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 1 14:38:37 PDT 2016


asbirlea marked an inline comment as done.

================
Comment at: lib/Transforms/Vectorize/LoadStoreVectorizer.cpp:197
@@ -196,3 +196,3 @@
     Changed |= vectorizeChains(StoreRefs);
   }
 
----------------
This was a leftover, I removed it.

================
Comment at: lib/Transforms/Vectorize/LoadStoreVectorizer.cpp:423
@@ +422,3 @@
+  assert(Chain.size() == ChainInstrs.size() &&
+         "Error checking if chain is vectorizable: All instructions in Chain should have been to ChainInsts from [From, To).");
+
----------------
I meant "added to", realized that shortly after the update. Reupdated.

================
Comment at: test/Transforms/LoadStoreVectorizer/x86/preserve-order32.ll:2
@@ +1,3 @@
+; RUN: opt -mtriple=x86-linux -load-store-vectorizer -S -o - %s | FileCheck %s
+
+target datalayout = "e-p:32:32-p1:64:64-p2:64:64-p3:32:32-p4:64:64-p5:32:32-p24:64:64-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-v256:256-v512:512-v1024:1024-v2048:2048-n32:64"
----------------
I don't think so. I can added it if you think this is the case.


http://reviews.llvm.org/D21934





More information about the llvm-commits mailing list