[PATCH] D21934: Address two correctness issues in LoadStoreVectorizer

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 1 13:39:05 PDT 2016


arsenm added a comment.

You're missing the new lit.local.cfg for x86


================
Comment at: lib/Transforms/Vectorize/LoadStoreVectorizer.cpp:197
@@ -196,2 +196,3 @@
     Changed |= vectorizeChains(StoreRefs);
+    DEBUG(dbgs() << "LSV: BB: " << *BB << '\n');
   }
----------------
This prints the entire block doesn't it? Maybe restrict to just the name? I think printing the entire block would be way too verbose for this, and you can already use the number to refer to the -print-before output

================
Comment at: lib/Transforms/Vectorize/LoadStoreVectorizer.cpp:422
@@ +421,3 @@
+  assert(Chain.size() == ChainInstrs.size() &&
+         "LSV: Error occured while checking if a chain is vectorizable");
+
----------------
This message isn't descriptive of what is wrong and doesn't need the LSV


http://reviews.llvm.org/D21934





More information about the llvm-commits mailing list