[PATCH] D18278: llvm-cov HTML Generation

Vedant Kumar via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 1 13:32:15 PDT 2016


vsk added a comment.

In http://reviews.llvm.org/D18278#472516, @harlanhaskins wrote:

> I don't think that's correct.
>
> If this is my folder structure:
>
> `swift-coverage`
>  └ `index.html`
>  └ `coverage`
>  └─ `/foo/bar/baz.cpp.html`
>
> and the links inside `index.html` begin with `swift-coverage`, then I can't click any of those links because they'll resolve to `swift-coverage/swift-coverage/foo`.


I don't see how that is possible. `LinkTarget` is set with `InToplevel=false` and `Relative=true`. So, `FullPath = "coverage"` before paths to source files are //appended// to it. At no point is the output directory included as a prefix or a suffix to `FullPath`. Can you break on `CoveragePrinterHTML::createIndexFile` and show it doing the wrong thing?


http://reviews.llvm.org/D18278





More information about the llvm-commits mailing list