[PATCH] D21927: [tsan] Synchronize leaving a GCD group with notifications

Kuba Brecka via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 1 07:09:21 PDT 2016


kubabrecka created this revision.
kubabrecka added reviewers: dvyukov, kcc, glider.
kubabrecka added subscribers: llvm-commits, zaks.anna, dcoughlin.
kubabrecka added a project: Sanitizers.
Herald added a subscriber: kubabrecka.

In the patch that introduced support for GCD barrier blocks, I removed releasing a group when leaving it (in dispatch_group_leave).  However, this is necessary to synchronize leaving a group and a notification callback (dispatch_group_notify).  Adding this back, simplifying dispatch_group_notify_f and adding a test case.

http://reviews.llvm.org/D21927

Files:
  lib/tsan/rtl/tsan_libdispatch_mac.cc
  test/tsan/Darwin/gcd-groups-leave.mm

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D21927.62492.patch
Type: text/x-patch
Size: 3894 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160701/2b58095d/attachment.bin>


More information about the llvm-commits mailing list