[PATCH] D21926: [ARM] Honour ABI for rem under -O0 for EABI, GNUEABI, Android and Musl

[Diana Picus via llvm-commits]

rovka added a comment.

I'm not sure this is the most principled way to test this. I think unit tests for getLibcallName might be a better idea, but I notice we don't have an awful lot of unit tests. Any suggestions?


================
Comment at: test/CodeGen/ARM/divmod-eabi.ll:20
@@ -19,3 +26,1 @@
 ; EABI: __aeabi_idivmod
-; EABI: mov [[div:r[0-9]+]], r0
-; EABI: mov [[rem:r[0-9]+]], r1
----------------
rengolin wrote:
> Removing the ABI registers will make the test a lot weaker and PR28164 tells me that this can already be broken in some cases.
> 
> Can you expand on what happens to the registers and why the test fails? My gut feeling is that a CHECK-DAG could fix the problem, but worst case scenario, we'll need two sets of CHECKs for O0 and O1.
I think it's just some spills getting in the way, I'll try CHECK-DAG. Thanks.


http://reviews.llvm.org/D21926