[PATCH] D21890: [ELF] - Do not error out when version declaration not found when building executable.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 1 03:41:28 PDT 2016

grimar added a comment.

In http://reviews.llvm.org/D21890#472210, @ruiu wrote:

> That logic makes sense, but this is also satisfies our need, no?
>   if (HaveNoVersionScript) {
>     Config->SymbolVersions.push_back(elf::Version(Version));
>     return Default ? I : (I | VERSYM_HIDDEN);
>   }

Technically yes. I just think than when linking DSO with versioned
symbols it is assumed that you have the script. If you do not have it then
it is more probably a mistake, like you forget to specify one. This code
can hide such possible error I think.
I would be more strict here and error out such cases.


More information about the llvm-commits mailing list