[PATCH] D21883: ThinLTO: Do not take into account whether a definition has multiple copies when promoting.

[Teresa Johnson via llvm-commits]

tejohnson added a comment.

In http://reviews.llvm.org/D21883#471613, @pcc wrote:

> (IMHO, the fact that we apply promotion and internalization to the index separately is very confusing, and we should fix that at some point.)


Yep, it is something we have talked about. See also the FIXME in llvm::thinLTOInternalizeModule:

  // FIXME: Eventually we should control promotion instead of promoting
  // and internalizing again.


http://reviews.llvm.org/D21883