[PATCH] D21829: CodeGen: Use MachineInstr& in TargetLowering, NFC

[Duncan P. N. Exon Smith via llvm-commits]

This was r274287, earlier today.  (Sorry I forgot to report on this thread until now.)

> On 2016-Jun-29, at 17:36, Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote:
> 
> 
>> On 2016-Jun-29, at 06:09, Ahmed Bougacha <ahmed.bougacha at gmail.com> wrote:
>> 
>> ab added subscribers: dylanmckay, ab.
>> ab accepted this revision.
>> ab added a reviewer: ab.
>> ab added a comment.
>> This revision is now accepted and ready to land.
>> 
>> Looks straightforward enough, go for it!
> 
> Thanks!  I'll aim to commit tomorrow when I have more time to watch bots.
> 
>> ================
>> Comment at: lib/Target/AVR/AVRISelLowering.h:95-97
>> @@ -94,5 +94,5 @@
>> 
>>  MachineBasicBlock *
>> -  EmitInstrWithCustomInserter(MachineInstr *MI,
>> +  EmitInstrWithCustomInserter(MachineInstr &MI,
>>                              MachineBasicBlock *MBB) const override;
>> 
>> ----------------
>> This isn't defined anywhere, but it looks like Dylan is working on completing r268722.
> 
> Found it because of the compiler warning for overriding functions having the wrong signature.  TBH, I don't think I could have updated these APIs correctly if we didn't have that warning; instead I'd have just been making the conversions explicit.
> 
>> 
>> 
>> http://reviews.llvm.org/D21829
>> 
>> 
>> 
>