[PATCH] D21636: [PM] LoopAccessInfo Refactor #2

Xinliang David Li via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 30 16:18:01 PDT 2016


Doh! That is indeed unfortunate. Will update the patch.

David

On Thu, Jun 30, 2016 at 4:14 PM, Sean Silva via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> silvas added a comment.
>
> Quick comment to avoid a buildbot issue.
>
>
> ================
> Comment at: include/llvm/Analysis/LoopAccessAnalysis.h:518
> @@ -517,1 +517,3 @@
>
> +  LoopAccessInfo(LoopAccessInfo &&LAI) = default;
> +  LoopAccessInfo &operator=(LoopAccessInfo &&LAI) = default;
> ----------------
> The issue with MSVC is actually that it can't synthesize this, so `=
> default` doesn't help unfortunately. You have to manually write out the
> entire move ctor like you had it. Just make sure to add a comment " // Hack
> for MSVC 2013 which seems like it can't synthesize this." or similar.
>
>
> http://reviews.llvm.org/D21636
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160630/2ccdb94f/attachment.html>


More information about the llvm-commits mailing list