[PATCH] D21636: [PM] LoopAccessInfo Refactor #2

Adam Nemet via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 30 11:40:14 PDT 2016


anemet added inline comments.

================
Comment at: include/llvm/Analysis/LoopAccessAnalysis.h:518-527
@@ -517,1 +517,12 @@
 
+  LoopAccessInfo(LoopAccessInfo &&LAI)
+      : PSE(std::move(LAI.PSE)), PtrRtChecking(std::move(LAI.PtrRtChecking)),
+        DepChecker(std::move(LAI.DepChecker)), TheLoop(LAI.TheLoop), DL(LAI.DL),
+        TLI(LAI.TLI), AA(LAI.AA), DT(LAI.DT), LI(LAI.LI),
+        NumLoads(LAI.NumLoads), NumStores(LAI.NumStores),
+        MaxSafeDepDistBytes(LAI.MaxSafeDepDistBytes), CanVecMem(LAI.CanVecMem),
+        StoreToLoopInvariantAddress(LAI.StoreToLoopInvariantAddress),
+        Report(std::move(LAI.Report)),
+        SymbolicStrides(std::move(LAI.SymbolicStrides)),
+        StrideSet(std::move(LAI.StrideSet)) {}
+
----------------
davidxl wrote:
> anemet wrote:
> > How are these different from the default move ctor/assignment operator?
> Sean mentioned that some compiler (MVS) does not generate default move ctor properly. 
So they're not different?

A comment explaining this would be good.


http://reviews.llvm.org/D21636





More information about the llvm-commits mailing list