[PATCH] D21449: Target independent codesize heuristics for Loop Idiom Recognition

[Chad Rosier via llvm-commits]

mcrosier added a comment.

Can you please provide full context with the diff.

Please provide code size numbers?


================
Comment at: lib/Transforms/Scalar/LoopIdiomRecognize.cpp:14
@@ -13,1 +13,3 @@
 //
+// If compiling for code size we use heuristics to prevent idiom recognition
+// if the resulting code could be larger than the code for the original loop.
----------------
I believe this comment needs to be updated now that this patch has been reduced in scope.

================
Comment at: lib/Transforms/Scalar/LoopIdiomRecognize.cpp:74
@@ +73,3 @@
+    "use-lir-code-size-heurs",
+    cl::desc("Use loop idiom recognition code size heuristics"),
+    cl::init(true), cl::Hidden);
----------------
Comment that this is only used when -Os/-Oz are specified.

================
Comment at: test/Transforms/LoopIdiom/lir-heurs-multi-block-loop.ll:133
@@ +132,3 @@
+
+;declare void @GF()
+;declare void @llvm.memset.p0i8.i64(i8* nocapture, i8, i64, i32, i1)
----------------
Please remove these two comments.


http://reviews.llvm.org/D21449