[PATCH] D21896: [compiler-rt] Fix broken (flaky) unittests based on FlagParser.

Etienne Bergeron via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 30 08:17:35 PDT 2016


etienneb added a comment.

In http://reviews.llvm.org/D21896#471316, @rnk wrote:

> lgtm This will cause stderr spew in the tests for unknown flags, but that seems OK.


Yes. But it's not too noisy.

  Note: Google Test filter = SanitizerCommon.*Flags
  [==========] Running 6 tests from 1 test case.
  [----------] Global test environment set-up.
  [----------] 6 tests from SanitizerCommon
  [ RUN      ] SanitizerCommon.BooleanFlags
  [       OK ] SanitizerCommon.BooleanFlags (0 ms)
  [ RUN      ] SanitizerCommon.IntFlags
  [       OK ] SanitizerCommon.IntFlags (8 ms)
  [ RUN      ] SanitizerCommon.StrFlags
  WARNING: found 2 unrecognized flag(s):
      --flag_name
      zzzzzzz
  [       OK ] SanitizerCommon.StrFlags (0 ms)
  [ RUN      ] SanitizerCommon.MultipleFlags
  [       OK ] SanitizerCommon.MultipleFlags (0 ms)
  [ RUN      ] SanitizerCommon.CommonSuffixFlags
  [       OK ] SanitizerCommon.CommonSuffixFlags (0 ms)
  [ RUN      ] SanitizerCommon.CommonFlags
  [       OK ] SanitizerCommon.CommonFlags (0 ms)
  [----------] 6 tests from SanitizerCommon (8 ms total)
  
  [----------] Global test environment tear-down
  [==========] 6 tests from 1 test case ran. (8 ms total)
  [  PASSED  ] 6 tests.


http://reviews.llvm.org/D21896





More information about the llvm-commits mailing list