[PATCH] D21883: ThinLTO: Do not take into account whether a definition has multiple copies when promoting.

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 29 21:35:29 PDT 2016


mehdi_amini added a comment.

"Either the definition is not exported, in which case the internalize phase sets its linkage to internal, or it is exported, in which case we need to promote linkage to weak"

We intentionally don't promote linkonce to weak when possible because linkonce -> weak promotion inhibit auto-hidden on MachO.
I should look at it again with the recent local_unnamed_addr attribute to understand exactly where we stand now and how this could affect our codegen.


http://reviews.llvm.org/D21883





More information about the llvm-commits mailing list