[PATCH] D21743: Convenience function for MCStreamer to get named sections when lowering.

Dean Michael Berris via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 29 18:04:30 PDT 2016


dberris marked 2 inline comments as done.
dberris added a comment.

Thanks -- I've moved this to MCContext instead.


================
Comment at: include/llvm/MC/MCStreamer.h:767
@@ +766,3 @@
+  /// used to further configure this named section.
+  virtual MCSection *getNamedGroupSection(StringRef Section,
+                                          StringRef Identifier,
----------------
rnk wrote:
> From reading the doc comments, this looks very ELF-specific. Maybe this should be getELFSectionInGroup? See a similar method getAssociativeCOFFSection.
Correct -- renamed to 'getELFNamedSection' instead?


http://reviews.llvm.org/D21743





More information about the llvm-commits mailing list