[PATCH] D21721: Object: Replace NewArchiveIterator with a simpler NewArchiveMember class. NFCI.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 29 12:14:54 PDT 2016


On 29 June 2016 at 01:11, Peter Collingbourne <peter at pcc.me.uk> wrote:
> pcc added inline comments.
>
> ================
> Comment at: include/llvm/Object/ArchiveWriter.h:25
> @@ +24,3 @@
> +  std::unique_ptr<MemoryBuffer> Buf;
> +  sys::TimeValue ModTime = sys::TimeValue::PosixZeroTime();
> +  unsigned UID = 0, GID = 0, Perms = 0644;
> ----------------
> rafael wrote:
>> Getting the time in here seems really odd.
> Hm? This is the (constant) epoch, not the current time.

oops. Never mind me. Taking another look.


More information about the llvm-commits mailing list