[PATCH] D21743: Convenience function for MCStreamer to get named sections when lowering.

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 29 11:31:30 PDT 2016


rnk added inline comments.

================
Comment at: lib/MC/MCAsmStreamer.cpp:1576
@@ +1575,3 @@
+
+MCSection *MCAsmStreamer::getNamedGroupSection(StringRef Section,
+                                               StringRef Identifier,
----------------
rafael wrote:
> I don't think this should be on the streamer, as the ELF and Asm implementations would be identical. This is just a convenience functions and should be implemented once in MCContext.
+1, it would live along with the other getELF*, getCOFF* etc methods. The XData and PData stuff lives here for bad reasons.


http://reviews.llvm.org/D21743





More information about the llvm-commits mailing list