[PATCH] D21526: [codeview] Improved array type support (multi dimension array)

[Reid Kleckner via llvm-commits]

rnk added inline comments.

================
Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:918
@@ +917,3 @@
+  if (Tag != dwarf::DW_TAG_member && Tag != dwarf::DW_TAG_typedef &&
+    Tag != dwarf::DW_TAG_const_type && Tag != dwarf::DW_TAG_volatile_type &&
+    Tag != dwarf::DW_TAG_restrict_type)
----------------
use clang-format to align Tag.

================
Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:933
@@ +932,3 @@
+  if (BaseType->getTag() == dwarf::DW_TAG_reference_type ||
+    BaseType->getTag() == dwarf::DW_TAG_rvalue_reference_type)
+    return DDTy->getSizeInBits();
----------------
use clang-format here

Can you give an example of when this would be needed? It would make a good test.

================
Comment at: test/DebugInfo/COFF/types-array-advanced.ll:17
@@ +16,3 @@
+;
+; typedef int T_INT;
+; T_INT typedef_arr[4];
----------------
Maybe make it 'typedef const volatile int T_INT' to cover a few more codepaths?


http://reviews.llvm.org/D21526