[PATCH] D21809: [SystemZ] Add support for .insn and .word/.short/.long/.quad directives

Ulrich Weigand via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 29 11:09:57 PDT 2016


uweigand added inline comments.

================
Comment at: test/MC/SystemZ/directive-insn.s:4
@@ +3,3 @@
+
+# TODO: No recognized E, RIE, RRF, SS, SSE, SSF, RSE, RSI instructions.
+
----------------
We really should have tests for all the formats, since they encode differently.

I do in fact see instructions already recognized for several of these:
RIE: CRJ*, RxSBG, ...
RRF: CRT*, LOCR(G), PPA, many FP insns
SS: MVC, NC, OC, XC, CLC
RSE: SRLG etc, LMG/STMG, ...

For the others, it might be good to add some instructions in those formats, they can be useful for inline asm anyway.


http://reviews.llvm.org/D21809





More information about the llvm-commits mailing list