[PATCH] D21817: [compiler-rt] Fix Sanitizer-common Unittests on win64

[Reid Kleckner via llvm-commits]

rnk added inline comments.

================
Comment at: lib/sanitizer_common/sanitizer_platform.h:171
@@ -170,3 +170,3 @@
 #ifndef SANITIZER_CAN_USE_ALLOCATOR64
-# if defined(__mips64) || defined(__aarch64__)
+# if defined(__mips64) || defined(__aarch64__) || defined(_WIN32)
 #  define SANITIZER_CAN_USE_ALLOCATOR64 0
----------------
`|| SANITIZER_WINDOWS` instead. Can you add comments about why we can't use the 64-bit allocator on win64 yet?

================
Comment at: lib/sanitizer_common/tests/sanitizer_printf_test.cc:27-28
@@ -29,1 +26,4 @@
+      (int)-1, (sptr)-2, // NOLINT
+      (unsigned)-4, (sptr)5, // NOLINT
+      (unsigned)10, (sptr)11, // NOLINT
       (void*)0x123, "_string_");
----------------
Should be `(uptr)5` and `(uptr)11`, right? Not that it matters a lot.

================
Comment at: lib/sanitizer_common/tests/sanitizer_test_main.cc:17
@@ +16,3 @@
+#ifdef _MSC_VER
+#pragma comment(linker, "/STACK:33554432")
+#endif
----------------
Which tests fail without this? 20MB seems like too much.


http://reviews.llvm.org/D21817