[PATCH] D21794: [ELF] - Added support for --unresolved-symbols option.

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/Config.h:40
@@ +39,3 @@
+  IgnoreInObjectFiles,
+  IgnoreInSharedLibs
+};
----------------
We always ignore undefined symbols in DSOs, so this enum shouldn't have IgnoreInSharedLibs. This also overlaps with NoinhibitExec, so it needs reorganization.

I think you want to define this in Config.

  enum { Error, Warn, Ignore };

and

 - set to Error by default or if --unresolved-symbols=IgnoreAll
 - set to Warn if --noinhibit-exec
 - set to Ignore if --unresolved-symbols={IgnoreAll,IgnoreInObjectFiles,IgnoreInSharedLibs}

================
Comment at: ELF/Writer.cpp:734
@@ +733,3 @@
+template <class ELFT>
+static void reportUndefinedFromSharedLibs(SymbolTable<ELFT> &Symtab) {
+  // In lld we do not report about undefines in DSO, so
----------------
We don't want to do this -- we don't care whether undefined symbols in DSOs are resolved or not unlike GNU linkers.


http://reviews.llvm.org/D21794