[PATCH] D21775: [InstCombine] Simplify and correct folding fcmps with the same children

[Eric Christopher via llvm-commits]

Sounds good. Thanks for checking.

On Tue, Jun 28, 2016, 9:26 PM Tim Shen <timshen at google.com> wrote:

> On Tue, Jun 28, 2016 at 7:32 PM Eric Christopher <echristo at gmail.com>
> wrote:
>
>> My guess is just automatic naming convention changes as part of the
>> script run. Try running it on the file without a change in tree to update
>> it, take a look at that and possibly minimize, and then once after your
>> patch.
>>
>
> Running it on the clean top of the tree produces no diffs. :)
>
> The name update_test_checks generated depends on the variable name
> produced by, in our case, opt:
>
> https://github.com/llvm-mirror/llvm/blob/master/utils/update_test_checks.py#L143
>
> As my patch goes in, the value names opt produce indeed change, which
> cause the CHECK variable names' change. I'm fine with the name changes as
> they are not stable anyway.
>
> We could change update_test_checks to always use its own names and
> counter, but that's another topic.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160629/0fb3c108/attachment.html>