[PATCH] D20847: BitCast infinite loop fix

[Eric Christopher via llvm-commits]

I've done it here:

Committing to https://llvm.org/svn/llvm-project/llvm/trunk ...
D test/Transforms/InstCombine/pr25342.ll
D test/Transforms/InstCombine/pr27703.ll
M lib/Transforms/InstCombine/InstCombineCasts.cpp
M lib/Transforms/InstCombine/InstCombineInternal.h
Committed r274094

I'll follow up to the latter of the original commits.

-eric

On Tue, Jun 28, 2016 at 11:46 AM Eric Christopher <echristo at gmail.com>
wrote:

> Hi All,
>
> Please go ahead and revert these. I've just noticed this thread, but
> Carrot is on vacation for a few weeks and so likely isn't reading this.
>
> Do follow up on the original commits and let him know what you've done.
>
> Thanks!
>
> -eric
>
> On Tue, Jun 28, 2016 at 10:08 AM Daniel Berlin <dberlin at dberlin.org>
> wrote:
>
>> In situations like this, where it is causing demonstrable issues and
>> appears broken, two "votes" are enough to revert the change.
>>
>> You should ask the author to revert the change, explicitly, in a separate
>> thread (a lot of people filter review mail).
>> If they don't do so expediently, you should revert it for them, and ask
>> them to take a look at fixing when they get a chance.
>>
>>
>>
>> On Tue, Jun 28, 2016 at 3:27 AM, Evgeny Stupachenko <evstupac at gmail.com>
>> wrote:
>>
>>> evstupac added a comment.
>>>
>>> Sorry if I am missing something.
>>> But is 2 votes here enough to revert the revisions?
>>> Should author do this? Or I can do this as well?
>>> There are still no vote from author and reviewer.
>>>
>>>
>>> Repository:
>>>   rL LLVM
>>>
>>> http://reviews.llvm.org/D20847
>>>
>>>
>>>
>>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160629/554d64d5/attachment.html>