[PATCH] D21775: [InstCombine] Simplify and correct folding fcmps with the same children

[Eric Christopher via llvm-commits]

On Tue, Jun 28, 2016 at 7:00 PM Tim Shen <timshen at google.com> wrote:

> On Tue, Jun 28, 2016 at 6:40 PM Eric Christopher <echristo at gmail.com>
> wrote:
>
>> Be nice to be able to split out the NFC testcase changes from the ones
>> that matter if you can.
>>
>
> I may misunderstood the "NFC testcase changes". Let me clarify. There are
> 3 kinds of changes:
> 1) there are a few re-naming changes that seem to be introduced by
> utils/update_test_checks.py, but I don't quite understand why. I used the
> same version of update_test_checks.py.
>
>
This is the set I meant.


> 1) is NFC; 2) is not NFC; 3) depends. But I don't know how to split these
> 3 kinds of changes. Previously I was explaining why splitting 2) and 3) is
> hard, but now I still have no clue why 1) happened.
>

My guess is just automatic naming convention changes as part of the script
run. Try running it on the file without a change in tree to update it, take
a look at that and possibly minimize, and then once after your patch.

-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160629/36b5cf47/attachment.html>