[PATCH] D21824: [LLD] Fix Clang-tidy modernize-use-emplace and Include What You Use warnings; other minor fixes

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 28 18:18:25 PDT 2016


I don't think we follow include-what-you-use in llvm/lld.

The emplace_back part is probably fine.

There are also other changes in the patch, like whitespace and adding
closing comments to namespaces. I am also not sold on their value.

On 28 June 2016 at 20:47, Eugene Zelenko via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Eugene.Zelenko created this revision.
> Eugene.Zelenko added a reviewer: ruiu.
> Eugene.Zelenko added a subscriber: llvm-commits.
> Eugene.Zelenko set the repository for this revision to rL LLVM.
>
> I checked this patch on my own build on RHEL 6. Regressions were OK.
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D21824
>
> Files:
>   COFF/Driver.cpp
>   ELF/Driver.cpp
>   ELF/InputFiles.cpp
>   ELF/OutputSections.cpp
>   ELF/Writer.cpp
>   lib/Driver/DarwinLdDriver.cpp
>   lib/ReaderWriter/MachO/CompactUnwindPass.cpp
>   lib/ReaderWriter/MachO/MachONormalizedFileBinaryReader.cpp
>   lib/ReaderWriter/MachO/MachONormalizedFileYAML.cpp
>   lib/ReaderWriter/YAML/ReaderWriterYAML.cpp
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>


More information about the llvm-commits mailing list