[PATCH] D21808: [WebAssembly] Handle debug information and virtual registers without crashing

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 28 16:56:13 PDT 2016


MatzeB added a comment.

In http://reviews.llvm.org/D21808#469407, @ddcc wrote:

> You're right, it looks like the isDebug parameter wasn't being set correctly on MachineOperand's, so the nodbg iterator didn't do anything. The updated patch sets that parameter now, but I'm not sure if it's in the correct place, or if the other parameters (e.g. isUse, isKill, etc) also need to be set.


DebugValue only has inputs so MachineOperand::IsDebug==1 should imply IsUse. Debug values should be excluded from any liveness calculation, so IsKill/IsDead/IsUndef should have no effect.


http://reviews.llvm.org/D21808





More information about the llvm-commits mailing list