[llvm] r274011 - Fix "not all control paths return a value" warning on MSVC

Vedant Kumar via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 28 11:03:22 PDT 2016


Sorry I missed this! Could you share which bot flagged this?

vedant

> On Jun 28, 2016, at 5:55 AM, Simon Pilgrim via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> Author: rksimon
> Date: Tue Jun 28 07:55:35 2016
> New Revision: 274011
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=274011&view=rev
> Log:
> Fix "not all control paths return a value" warning on MSVC
> 
> Modified:
>    llvm/trunk/tools/llvm-cov/SourceCoverageView.cpp
> 
> Modified: llvm/trunk/tools/llvm-cov/SourceCoverageView.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-cov/SourceCoverageView.cpp?rev=274011&r1=274010&r2=274011&view=diff
> ==============================================================================
> --- llvm/trunk/tools/llvm-cov/SourceCoverageView.cpp (original)
> +++ llvm/trunk/tools/llvm-cov/SourceCoverageView.cpp Tue Jun 28 07:55:35 2016
> @@ -102,6 +102,7 @@ SourceCoverageView::create(StringRef Sou
>     return llvm::make_unique<SourceCoverageViewText>(SourceName, File, Options,
>                                                      std::move(CoverageInfo));
>   }
> +  llvm_unreachable("Unknown coverage output format!");
> }
> 
> void SourceCoverageView::print(raw_ostream &OS, bool WholeFile,
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits



More information about the llvm-commits mailing list