[PATCH] D8285: [compiler-rt] Add AtosSymbolizer and DlAddrSymbolizer as fallbacks for OS X

Andrew C. Morrow via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 28 09:27:33 PDT 2016


acmorrow added a subscriber: acmorrow.
acmorrow added a comment.

This change appears to have had the unfortunate effect that setting ASAN_SYMBOLIZER_PATH=/usr/bin/llvm-symbolizer-3.8 in the environment no longer works, because the strcmp on line 423 is looking for the exact string 'llvm-symbolizer'.

That is unfortunate, since on some Linux distributions like Ubuntu the llvm-symbolizer binaries are always installed with a version suffix. On my Ubuntu 16.04 system, for instance, the symbolizer is in /usr/bin/llvm-symbolizer-3.8. Adjusting PATH doesn't help in that case, for obvious reasons. So it appears that after the above change the only way to deal with this on Ubuntu is to make a temporary copy of /usr/bin/llvm-symbolizer-3.8 to a temp directory under the name llvm-symbolizer, and then either add that to PATH or point ASAN_SYMBOLIZER_PATH at the temporary llvm-symbolizer file.

If this was an intended behavior change, then OK, but if unintended it feels like a regression in 3.7 and 3.8.


http://reviews.llvm.org/D8285





More information about the llvm-commits mailing list