[PATCH] D21793: [SystemZ] Add floating-point test data class instructions.

Ulrich Weigand via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 28 08:40:32 PDT 2016


uweigand added a comment.

See inline comment.  Also, it might be good to add some tests to insns-bad.s as well.

Otherwise LGTM.


================
Comment at: lib/Target/SystemZ/SystemZInstrFormats.td:1959
@@ -1958,1 +1958,3 @@
 
+class TestRXE<string mnemonic, bits<16> opcode, SDPatternOperator operator,
+              RegisterOperand cls>
----------------
Please add a comment about the new "Test" category above where the other categories (like Unary etc.) are documented.


Repository:
  rL LLVM

http://reviews.llvm.org/D21793





More information about the llvm-commits mailing list