[llvm] r273854 - [gold] Fix test to not assume it runs on x86 hardware.

Arnaud De Grandmaison via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 28 01:38:41 PDT 2016


I added your change at r274000.

Cheers,
Aenaud

> -----Original Message-----
> From: H.J. Lu [mailto:hjl.tools at gmail.com]
> Sent: 27 June 2016 17:06
> To: Arnaud De Grandmaison; Rafael Ávila de Espíndola
> Cc: llvm-commits
> Subject: Re: [llvm] r273854 - [gold] Fix test to not assume it runs on x86
> hardware.
>
> On Mon, Jun 27, 2016 at 2:13 AM, Arnaud A. de Grandmaison via llvm-
> commits <llvm-commits at lists.llvm.org> wrote:
> > Author: aadg
> > Date: Mon Jun 27 04:13:03 2016
> > New Revision: 273854
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=273854&view=rev
> > Log:
> > [gold] Fix test to not assume it runs on x86 hardware.
> >
> > Modified:
> >     llvm/trunk/test/tools/gold/X86/relax-relocs.ll
> >
> > Modified: llvm/trunk/test/tools/gold/X86/relax-relocs.ll
> > URL:
> > http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/gold/X86/rel
> > ax-relocs.ll?rev=273854&r1=273853&r2=273854&view=diff
> >
> ==========================================================
> ============
> > ========
> > --- llvm/trunk/test/tools/gold/X86/relax-relocs.ll (original)
> > +++ llvm/trunk/test/tools/gold/X86/relax-relocs.ll Mon Jun 27 04:13:03
> > +++ 2016
> > @@ -7,6 +7,8 @@
> >  ; Test that we produce R_X86_64_GOTPCREL instead of
> > R_X86_64_GOTPCRELX  ; CHECK: R_X86_64_GOTPCREL foo
> >
> > +target triple = "x86_64-unknown-linux-gnu"
> > +
> >  @foo = external global i32
> >  define i32 @bar() {
> >    %t = load i32, i32* @foo
> >
>
> This patch is also needed.  Please check it in for me.
>
> Thanks.
>
> --
> H.J.
> ----
>
> diff --git a/test/tools/gold/X86/relax-relocs.ll b/test/tools/gold/X86/relax-rel
> ocs.ll index bc13c30..13a813f 100644
> --- a/test/tools/gold/X86/relax-relocs.ll
> +++ b/test/tools/gold/X86/relax-relocs.ll
> @@ -1,5 +1,5 @@
>  ; RUN: llvm-as %s -o %t.o
> -; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \
> +; RUN: %gold -m elf_x86_64 -plugin %llvmshlibdir/LLVMgold.so \
>  ; RUN:    --plugin-opt=save-temps \
>  ; RUN:    -shared %t.o -o %t.so
>  ; RUN: llvm-readobj -r %t.so.o | FileCheck %s

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


More information about the llvm-commits mailing list