[PATCH] D21645: [CFLAA] Propagate StratifiedAttrs from callee to caller

[George Burgess IV via llvm-commits]

> No problem.  Well, except you didn't follow me to the very end.  I think
that 'one' really has to become 1ULL, not just 1U.  If only because only
the latter makes the warning actually go away.  1U is unsigned int, but the
constructor for std::bitset<> being used here takes unsigned long long.

Ah, I was hoping I could get away with not doing that, since the bitset
we're ultimately creating is only 32 bits wide. Alas, it seems that
compilers can be picky sometimes. :)

Swapped to 1ULL in r273955; thanks again.

> And at ~2000 post/week, I wasn't sure I wanted to subscribe to that flood
just yet.

Totally understandable.

On Mon, Jun 27, 2016 at 3:27 PM, Hans-Bernhard Bröker <HBBroeker at t-online.de
> wrote:

> Am 27.06.2016 um 20:45 schrieb George Burgess IV:
>
>> Fixed in r273902. Thanks for pinging this!
>>
>
> No problem.  Well, except you didn't follow me to the very end.  I think
> that 'one' really has to become 1ULL, not just 1U.  If only because only
> the latter makes the warning actually go away.  1U is unsigned int, but the
> constructor for std::bitset<> being used here takes unsigned long long.
>
> (Also, in the future, if you could add reviewers/the patch author to the
>> CC line for things like this, that would be really helpful. Many of us
>> have lots of email filters set up, so being cc'ed makes a difference. :) )
>>
>
> I'll admit I didn't search very hard, but the list was the only address I
> actually found.  And at ~2000 post/week, I wasn't sure I wanted to
> subscribe to that flood just yet.
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160627/f1910bb0/attachment.html>